Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-36686: [C++] Pass CMAKE_OSX_SYSROOT to external projects #36706

Merged
merged 2 commits into from
Jul 16, 2023
Merged

GH-36686: [C++] Pass CMAKE_OSX_SYSROOT to external projects #36706

merged 2 commits into from
Jul 16, 2023

Conversation

kou
Copy link
Member

@kou kou commented Jul 15, 2023 •
edited by github-actions bot
Loading

Rationale for this change

If we use different macOS SDK in Apache Arrow C++ and bundled projects, it will cause some problems such as a build error.

What changes are included in this PR?

Pass CMAKE_OSX_SYSROOT explicitly to external projects.

Are these changes tested?

Yes.

Are there any user-facing changes?

Yes.

@kou
Copy link
Member Author

kou commented Jul 15, 2023

@github-actions crossbow submit r-binary-packages

@github-actions
Copy link

⚠️ GitHub issue #36686 has been automatically assigned in GitHub to PR creator.

@github-actions

This comment was marked as outdated.

Sign in to view
@kou
Copy link
Member Author

kou commented Jul 16, 2023

@github-actions crossbow submit r-binary-packages

@github-actions
Copy link

Revision: 8b27832

Submitted crossbow builds: ursacomputing/crossbow @ actions-5e221cbb49

Task Status
r-binary-packages Github Actions

@kou kou marked this pull request as ready for review July 16, 2023 09:14
@kou kou requested a review from paleolimbot July 16, 2023 09:14
@kou
Copy link
Member Author

kou commented Jul 16, 2023

The Big Sur job is still failing: https://github.com/ursacomputing/crossbow/actions/runs/5566749960/jobs/10168239125
But it's caused by OpenSSL (#36456): Symbol not found: _EVP_DigestSignUpdate

@paleolimbot
Copy link
Member

Thank you!

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting committer review Awaiting committer review labels Jul 16, 2023
@paleolimbot
Copy link
Member

I created #36707 for the CI failures (they are happening on main as well). They are also OpenSSL-related.

@paleolimbot paleolimbot merged commit 9ebb3d7 into apache:main Jul 16, 2023
31 of 33 checks passed
@paleolimbot paleolimbot removed the awaiting merge Awaiting merge label Jul 16, 2023
@kou kou deleted the r-autobrew branch July 16, 2023 20:21
raulcd pushed a commit that referenced this pull request Jul 17, 2023
@kou @raulcd
GH-36686: [C++] Pass CMAKE_OSX_SYSROOT to external projects (#36706)
137e50d 
### Rationale for this change

If we use different macOS SDK in Apache Arrow C++ and bundled projects, it will cause some problems such as a build error.

### What changes are included in this PR?

Pass `CMAKE_OSX_SYSROOT` explicitly to external projects.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

Yes.
* Closes: #36686

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Dewey Dunnington <dewey@fishandwhistle.net>
@paleolimbot paleolimbot mentioned this pull request Jul 17, 2023
Closed
chelseajonesr pushed a commit to chelseajonesr/arrow that referenced this pull request Jul 20, 2023
@kou @chelseajonesr
apacheGH-36686: [C++] Pass CMAKE_OSX_SYSROOT to external projects (ap…
802c77a 
…ache#36706)

### Rationale for this change

If we use different macOS SDK in Apache Arrow C++ and bundled projects, it will cause some problems such as a build error.

### What changes are included in this PR?

Pass `CMAKE_OSX_SYSROOT` explicitly to external projects.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

Yes.
* Closes: apache#36686

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Dewey Dunnington <dewey@fishandwhistle.net>
@conbench-apache-arrow
Copy link

After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 9ebb3d7.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about possible false positives for unstable benchmarks that are known to sometimes produce them.

R-JunmingChen pushed a commit to R-JunmingChen/arrow that referenced this pull request Aug 20, 2023
@kou @R-JunmingChen
apacheGH-36686: [C++] Pass CMAKE_OSX_SYSROOT to external projects (ap…
5abc386 
…ache#36706)

### Rationale for this change

If we use different macOS SDK in Apache Arrow C++ and bundled projects, it will cause some problems such as a build error.

### What changes are included in this PR?

Pass `CMAKE_OSX_SYSROOT` explicitly to external projects.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

Yes.
* Closes: apache#36686

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Dewey Dunnington <dewey@fishandwhistle.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paleolimbot paleolimbot paleolimbot approved these changes

@assignUser assignUser Awaiting requested review from assignUser assignUser is a code owner

@raulcd raulcd Awaiting requested review from raulcd raulcd is a code owner

Assignees
No one assigned
Labels
Component: C++
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[R] MacOS autobrew jobs fail to build Google Cloud Storage formula (bad curl headers?)
2 participants
@kou @paleolimbot